Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade CSI driver image versions in windows vhd #3982

Merged
merged 1 commit into from
Jan 24, 2024
Merged

chore: upgrade CSI driver image versions in windows vhd #3982

merged 1 commit into from
Jan 24, 2024
+25 −24

Conversation

andyzhangx
Copy link
Collaborator

@andyzhangx andyzhangx commented Jan 19, 2024 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
chore: upgrade CSI driver image versions in windows vhd

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@andyzhangx andyzhangx added VHD your change will be included in the following VHDs windows labels Jan 19, 2024
@coveralls
Copy link

coveralls commented Jan 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7636727704

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.313%
Totals Coverage Status
Change from base Build 7636523590: 0.0%
Covered Lines: 2285
Relevant Lines: 2881
💛 - Coveralls

@ShiqianTao ShiqianTao self-requested a review January 19, 2024 06:43
@andyzhangx andyzhangx force-pushed the andyzhangx/upgrade-csi-driver-image-versions branch from 98d9e6a to 006e66d Compare January 19, 2024 06:50
@andyzhangx andyzhangx force-pushed the andyzhangx/upgrade-csi-driver-image-versions branch from 006e66d to 426b8a3 Compare January 19, 2024 07:58
@andyzhangx andyzhangx force-pushed the andyzhangx/upgrade-csi-driver-image-versions branch from 426b8a3 to d80992e Compare January 19, 2024 08:21
@andyzhangx andyzhangx force-pushed the andyzhangx/upgrade-csi-driver-image-versions branch from 8ac3ab0 to a909473 Compare January 19, 2024 08:48
AbelHu
AbelHu approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@AbelHu AbelHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR. Please merge this PR after the Windows/Linux VHD building tests pass.

@andyzhangx andyzhangx enabled auto-merge (squash) January 19, 2024 11:35
@andyzhangx andyzhangx force-pushed the andyzhangx/upgrade-csi-driver-image-versions branch from 8437e20 to fae7579 Compare January 22, 2024 09:26
@andyzhangx
Copy link
Collaborator Author

@ganeshkumarashok do you know what this error mean? are we running out of image space since we are adding some images in this PR or it's just another different test error?

https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=86099243&view=results

==> azure-arm: dpkg: unrecoverable fatal error, aborting:
==> azure-arm:  unable to fill /var/lib/dpkg/updates/tmp.i with padding: No space left on device
==> azure-arm: + timeout 120 apt-get purge -o Dpkg::Options::=--force-confold -y snapd

AbelHu
AbelHu requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@AbelHu AbelHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux VHD build failed

@andyzhangx andyzhangx force-pushed the andyzhangx/upgrade-csi-driver-image-versions branch from 94d12cb to 76882fd Compare January 24, 2024 03:55
@andyzhangx andyzhangx force-pushed the andyzhangx/upgrade-csi-driver-image-versions branch from 59b0026 to ff502ae Compare January 24, 2024 07:11
@andyzhangx andyzhangx changed the title chore: upgrade CSI driver image versions in vhd chore: upgrade CSI driver image versions in windows vhd Jan 24, 2024
AbelHu
AbelHu approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@AbelHu AbelHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@andyzhangx andyzhangx merged commit 007b13a into master Jan 24, 2024
17 of 21 checks passed
@andyzhangx andyzhangx deleted the andyzhangx/upgrade-csi-driver-image-versions branch January 24, 2024 07:56
@andyzhangx andyzhangx mentioned this pull request Jan 24, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbelHu AbelHu AbelHu approved these changes

@ShiqianTao ShiqianTao ShiqianTao approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@cameronmeissner cameronmeissner Awaiting requested review from cameronmeissner cameronmeissner is a code owner

@UtheMan UtheMan Awaiting requested review from UtheMan UtheMan is a code owner

@ganeshkumarashok ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

@anujmaheshwari1 anujmaheshwari1 Awaiting requested review from anujmaheshwari1 anujmaheshwari1 is a code owner

@AlisonB319 AlisonB319 Awaiting requested review from AlisonB319 AlisonB319 is a code owner

@Devinwong Devinwong Awaiting requested review from Devinwong Devinwong is a code owner

@lilypan26 lilypan26 Awaiting requested review from lilypan26 lilypan26 is a code owner

@junjiezhang1997 junjiezhang1997 Awaiting requested review from junjiezhang1997 junjiezhang1997 is a code owner

Assignees
No one assigned
Labels
VHD your change will be included in the following VHDs windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andyzhangx @coveralls @AbelHu @ShiqianTao